PsrAutoloadingFixer - Fix PSR autoloading outside configured directory #5421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
force-pushed
the
fix-psr-autoloading
branch
from
8474609 to
d5aa911
Compare
keradus
reviewed
Jan 9, 2021
kelunik
added a commit
to amphp/php-cs-fixer-config
that referenced
this pull request
Jan 11, 2021
kubawerlos
approved these changes
Jan 12, 2021
|
Thanks for the PR as bug fix 👍 Maybe we should validate that the configured directory exists or at least check the result of the |
|
should/will this PR als fix #5537 ? |
|
@clxmstaab no, |
keradus
force-pushed
the
fix-psr-autoloading
branch
from
c20aafb to
02d1ade
Compare
keradus
force-pushed
the
fix-psr-autoloading
branch
from
02d1ade to
55a9991
Compare
|
I let myself to apply suggestion of @SpacePossum |
keradus
changed the title
|
Thank you @kelunik. |
|
Thank you, we can finally enable the rule again. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes amphp/php-cs-fixer-config#5.