Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock file marking #474

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

szepeviktor
Copy link
Contributor

Composer's lock file is ours, it is generated by Composer.

https://github.com/github-linguist/linguist/blob/main/docs/overrides.md#summary

@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 19, 2025

The problem I see is that generated is marked this way:

Excluded from stats, hidden in diffs

The hidden in diffs part is what I don't like so much. Do you know if there is still an option then to see the diff in the PR github view?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 19, 2025

Do you know if there is still an option then to see the diff in the PR github view?

Hidden means:
image

Only the content is hidden.

@alexander-schranz alexander-schranz merged commit 418c4dd into PHP-CMSIG:0.6 Jan 19, 2025
44 of 47 checks passed
@alexander-schranz
Copy link
Member

@szepeviktor Thanks!

@alexander-schranz alexander-schranz added the DX Improves the developer experience label Jan 19, 2025
@szepeviktor
Copy link
Contributor Author

You're welcome.

@szepeviktor szepeviktor deleted the patch-1 branch January 19, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Improves the developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants