Move bulk method from own Interface to IndexerInterface #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
Adapter: Elasticsearch
|
@tacman FYI the BulkableIndexerInterface got removed as not required as we could support bulk operations for all adapters we could safely add it to the |
Merged
alexander-schranz
added a commit
that referenced
this pull request
Oct 8, 2024
Was forgotten to be adopted in #435.
alexander-schranz
added a commit
to PHP-CMSIG/seal
that referenced
this pull request
Oct 8, 2024
Was forgotten to be adopted in PHP-CMSIG/search#435.
alexander-schranz
added a commit
to PHP-CMSIG/seal-symfony-bundle
that referenced
this pull request
Oct 8, 2024
Was forgotten to be adopted in PHP-CMSIG/search#435.
alexander-schranz
added a commit
to PHP-CMSIG/seal-mezzio-module
that referenced
this pull request
Oct 8, 2024
Was forgotten to be adopted in PHP-CMSIG/search#435.
alexander-schranz
added a commit
to PHP-CMSIG/seal-yii-module
that referenced
this pull request
Oct 8, 2024
Was forgotten to be adopted in PHP-CMSIG/search#435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the bulk method from own interface to indexer interface. So without any checks we can use bulk everywhere as supported by all adapters currently.
None BC Break as old BulkableIndexerInterface was not part of any release yet.