Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stricter validation for field names #427

Conversation

alexander-schranz
Copy link
Member

This outputs a error message for an unexpected input for the field name. We validate currently two things.

fix #426

FYI @Toflar

@alexander-schranz alexander-schranz added SEAL Core Seal Core related issue DX Improves the developer experience labels Oct 6, 2024
@alexander-schranz
Copy link
Member Author

alexander-schranz commented Oct 6, 2024

PS: I'm using internal assert of PHP to avoid overheads in validation for production. For CI using the widely used https://github.com/shivammathur/setup-php It is required to configure zend.assertions=1 via:

            - name: Install and configure PHP
              uses: shivammathur/setup-php@v2
              with:
                  php-version: ${{ matrix.php-version }}
                  tools: 'composer:v2'
                  ini-values: memory_limit=-1, zend.assertions=1

FYI: @Toflar

@alexander-schranz alexander-schranz force-pushed the enhancement/stricter-field-name-validation branch from cb148f3 to 3557703 Compare October 6, 2024 10:54
@alexander-schranz alexander-schranz merged commit 205cd22 into PHP-CMSIG:0.6 Oct 6, 2024
28 of 32 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/stricter-field-name-validation branch October 6, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Improves the developer experience SEAL Core Seal Core related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifiers for meilisearch and probably others need to be checked
1 participant