Cleanup create_trajectories.sh with shellcheck #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 46 46
Lines 6720 6720
Branches 754 754
=======================================
Hits 6239 6239
Misses 469 469
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
danielhollas
added
the
refactor
|
Cheers @JanosJiri. I'll merge after Jack tests it out on squirrel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cosmetic changes and cleanup.
One functional change: It is now possible to specify
submit_command=bashif the trajectories are to be run directly on a machine (e.g. Squirrel or Hamilton nodes) instead of submitting to queing system. In this case, the launch scriptr.abindoesn't need to be provided in the template directory.