-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store problem configuration in Problem #326
Conversation
45c29b3
to
2576270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
===========================================
+ Coverage 74.24% 74.38% +0.13%
===========================================
Files 53 53
Lines 5168 5196 +28
Branches 910 910
===========================================
+ Hits 3837 3865 +28
Misses 984 984
Partials 347 347 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could also add filename metadata to the specific table objects, so that e.g. the top-half of the measurements is saved to measurements1.tsv
and the bottom-half to measurements2.tsv
. Fine to merge already
Yeah, I was thinking along the same lines. The problem is, we'd probably have to store the filenames in a new column, which people might not like. Storing it elsewhere, will cause issues in case the dataframe gets modified. |
Yes, I think it will be easier to support with #337 |
2576270
to
5bb6cf2
Compare
Introduces Problem.config which contains the info from the PEtab yaml file. Sometimes it is convenient to have the original filenames around. Closes PEtab-dev#324.
5bb6cf2
to
31d64ea
Compare
Introduces `v2.Problem.config` which contains the info from the PEtab yaml file. The same as PEtab-dev#326, but for `v2.Problem`.
Introduces `v2.Problem.config` which contains the info from the PEtab yaml file. The same as #326, but for `v2.Problem`. --------- Co-authored-by: Dilan Pathirana <[email protected]>
Introduces
Problem.config
which contains the info from the PEtab yaml file.Sometimes it is convenient to have the original filenames around.
Pydantic gives more helpful error messages than
jsonschema
in case of incorrect inputs. Later on, this could replacejsonschema
completely.If accepted, I will add the same for
petab.v2.Problem
.Related to #324.