Store problem configuration in Problem #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces Problem.config which contains the info from the PEtab yaml file. Sometimes it is convenient to have the original filenames around. Closes PEtab-dev#324.
dweindl
force-pushed
the
problem_config
branch
from
45c29b3
to
2576270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
===========================================
+ Coverage 74.92% 75.06% +0.14%
===========================================
Files 52 52
Lines 4913 4941 +28
Branches 845 845
===========================================
+ Hits 3681 3709 +28
Misses 923 923
Partials 309 309 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Problem.configwhich contains the info from the PEtab yaml file.Sometimes it is convenient to have the original filenames around.
Pydantic gives more helpful error messages than
jsonschemain case of incorrect inputs. Later on, this could replacejsonschemacompletely.If accepted, I will add the same for
petab.v2.Problem.Related to #324.