Updated build/lisp.tcl to not specify FN2 for those lisp compilations #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where the default of > would be more appropriate. This fixes, in particular the incorrect compilation of LIBDOC; TIME KMP8 instead of LIBDOC; TIME KMP9. Resolves #1091.
atsampson
approved these changes
Jul 22, 2018
|
Yes. There have been times when the next version of a libdoc source changed authors and versions, and where > would do the wrong thing in the face of both versions. But that doesn’t apply here. On the other hand, it isn’t clear to me that this version of LIBDOC; TIME KMP8 should be called that since KMP didn’t make the change. We probably should have used yours or my initials. Had we used mine, that issue would have arisen since KMP8 is > EJS9! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where the default of > would be more appropriate. This fixes, in
particular the incorrect compilation of LIBDOC; TIME KMP8 instead of
LIBDOC; TIME KMP9. Resolves #1091.