Remove wx variable types from config code. Rewrite Portable mode. #4005
Conversation
weirdbeardgame
changed the title
weirdbeardgame
force-pushed
the
removeWX
branch
6 times, most recently
from
e066506 to
c42e101
Compare
weirdbeardgame
changed the title
There was a problem hiding this comment.
Hopefully someone more familiar with unicode path handling can chime in, I think we want to use std::wstring more to avoid issues, but I'm not 100% sure. That's really the only thing that jumps out at me as a concern.
The lion share of these changes are just patching up the file-path related usages around the codebase which i would expect. These changes shallowly touch the following "no-longer-plugins" configuration/logging so we'll probably want to do some brief testing in the future around those:
- PAD
- CDVD
- DEV9
- SPU2
Given the re-write to portable mode, it would be nice if we could detect and flag portable mode earlier as discovered here - #3991 (comment)
You want to use We have a file: It can convert utf8 (string) to utf16 (wstring). If needed you can add a function which does the opposite. |
Yeah that's fine I can do that. It's mostly in lieu of converting to wxString since it's a wchar_t type or UTF16 using fs::path's wstring |
weirdbeardgame
force-pushed
the
removeWX
branch
2 times, most recently
from
f1ca945 to
c4d4d3d
Compare
weirdbeardgame
force-pushed
the
removeWX
branch
11 times, most recently
from
32a4876 to
0db1a79
Compare
weirdbeardgame
force-pushed
the
removeWX
branch
3 times, most recently
from
b121323 to
0db1a79
Compare
…struct stream. Fixed yaml output stream handling, will reset portable.yaml if it gets into a bad state
…factor pass, focused on cleaning up string conversions
…Utils: return file name
…removed duplicate code. Fix wxConfigFile singleton initialization
….cpp: Fix Mac return in GetProgramDataDir
…al path from relative
… Construct fullpath to bios with dolder and filename
…ed formatting and used c_str
Moved Portable file to pcsx2/Docs. This prevents it being modified when it's set to false. Ignore bin portable file in git. VS: Post-build event to copy portable.yaml file into /bin with escape-hatch If a /bin/portable.build.yaml file is detected, it will use that instead of the pcsx2/Docs/portable.yaml file. This is to maintain parity with the CMake solution which is to always overwrite the file while still allowing a decent method to bypass that behaviour.
…nd RunElf with junk data
…etPath for IniInterface to do it's job
…oesExist function
…l functions with proper filesystem usages
…it defined and will conflict AppUserMode.cpp: Added error checking to fix codacity error. AppConfig.cpp: Fix a codacity error
…efrences to plugins AppConfig: Fix CurrentIso Save
…de. Fixed Elf and set CD source
weirdbeardgame
force-pushed
the
removeWX
branch
from
9cb771d to
d7c8015
Compare
|
Closing as it's not being worked on, when work resumes pr can be reopened. |
This PR is a total rewrite of AppUserMode and the start of a rewrite to Config.h pcsx2Config.cpp AppConfig. This clears a whole chunk of needless wx variable type usage in favor of standard std / filesystem ones. This casts all types back to their wx counterparts when needed.