Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPU: Removed forced rounding on DIV/SQRT/RSQRT (Do Not merge!) #3816

Closed
wants to merge 1 commit into from

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Oct 11, 2020

Added gamefix for Mortal Kombat Shaolin Monks

Description:

For a very long time PCSX2 has had the rounding mode of DIV, SQRT and RSQRT on the FPU forced to "Nearest" instead of Chop/Zero (unless you use the Neg DIV hack), presumably because it fixed some game and seemed like a good idea. This PR aims to remove it, but it needs to be tested thoroughly before we even think about merging it. I suspect a few games will require a gamefix (like Shaolin Monks did) but many other games might see a positive benefit from doing this.

Please reply below if any game needs any other rounding setting and if it has any adverse effects on the game.

Improvements:
Stuntman - AI is improved (but still not brilliant)
Freakstyle - Less issue with invisible walls
ONI - Interactable doors now fixed

Regressions:
Mortal Kombat Shaolin Monks - Texture sizes, fixed by setting rounding to positive

Added gamefix for Mortal Kombat Shaolin Monks
@refractionpcsx2 refractionpcsx2 marked this pull request as draft October 11, 2020 21:33
@boringhexi
Copy link
Contributor

May we also list games that seem unaffected? This could save other testers some time.

Gitaroo Man: Did not notice any new graphical bugs, nor any improvement of the existing graphical bug (i.e. Stage 4 flashing). (Tested 30-60 seconds of each stage including the multiplayer one.)

@RedDevilus
Copy link
Contributor

RedDevilus commented Nov 23, 2020

Better to test several games and mention where you see improvements or more importantly problems like regressions. Unless you want to mention several of the 4K distinct games (or 10K+ entries of the GameDB). Unaffected games don't really lower or speed-up the merging process in this manner. Or you can just say your collection or say something like 10+ are working like before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants