Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Add new HPO - Align to Native With Texture Offset #12350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Feb 23, 2025

Description of Changes

New Half Pixel Offset option, based on Align Native but with texture adjustment and removes a very annoying vertex offset.

Rationale behind Changes

The vertex offset was causing problems in the RT in RT branch due to things being drawn offset in to a target, but by default the option leaves the first pixel blank due to a forced offset, this gets around that but needs to adjust texture coordinates also.

Suggested Testing Steps

Test games with the new option under the HPO upscaling fixes.

Known to be better for Ace Combat games, Catwoman, Madagascar and potentially others with borders. GOW also looks better on the RT in RT branch, as well as being required for FF7 DoC and Project Snowblind to avoid bad textures.

Catwoman:
Master:
image

PR with new option:
image

Madagascar:
Master:
image

Master with Align to Native:
image

PR With new options:
image

@bigol83
Copy link

bigol83 commented Feb 23, 2025

Align to Native

atn default

Align to Native Texture Offset

atn texture offset

ATN Texture Offset is less blurry

@mirh
Copy link

mirh commented Feb 24, 2025

Uhm..? I'd be curious to know where in ace combat this would be better, because in AC4 it seems worse.
Original
Align to Native
Align to Native - Texture
(this was with native scaling set on "aggressive".. without it, there is actually even an odd vertical line on the right edge)

@refractionpcsx2
Copy link
Member Author

idk how you got those results, but:

Original:

image

ATN (but keep in mind in another seen this absolutely breaks the clouds):

image

ATN Texture (which doesn't break the clouds):

image

That's why I think it's better for Ace Combat.

@mirh
Copy link

mirh commented Feb 24, 2025

With original I meant software (you can see how much more it's lower res).
And I couldn't avoid to notice how normal ATN is pretty much (and finally!) its direct equivalent - just HD.

Then yeah, I saw just now that while actually flying ATNT fixes the sky.

@mirh
Copy link

mirh commented Feb 24, 2025

Not bad at all now.
Then of course you do you (and I can guess that "texture offset" means that you should necessarily expect a bit of a constant shift in the position of stuff), but if I had to raise an objection the blur effect is still kinda screwed. Most notably it's no longer centred around the front landing gear (you can only see it, much stronger, on the right) and that metal thingy on the superstructure on the left with the ISAF logo has such a trail..

@AmyRoxwell
Copy link

Pretty interesting! Will be testing this on my games and see how much this helps 👀

@pgert
Copy link
Contributor

pgert commented Feb 25, 2025

In "pcsx2/ImGui/FullscreenUI.cpp" it's still "Align To Native" & "Align to Native - With Texture Offset".
Any comment?

@AmyRoxwell
Copy link

AmyRoxwell commented Feb 25, 2025

Might be worth checking SOTN with this, I had been testing with Native Scaling set to Normal and the water doesn't add the extra white lines while underwater.

The settings used:
Screenshot_20250225_002604
Here is a Multi-Frame GS dump:
https://drive.google.com/file/d/1b2jj4-KmXImaTL2PnmR9t7GI__b83YE7/view?usp=sharing

And a single frame dump if you want to quickly see it:
Single Frame SOTC.zip

Picture Comparisons:
Master:
Master

PR with Native Scaling set to Normal
PR

Software:
Software

If you have any other GSDumps for SOTC that might show weird upscaling issues, it might be worth checking on those too.

@refractionpcsx2
Copy link
Member Author

refractionpcsx2 commented Feb 25, 2025

In "pcsx2/ImGui/FullscreenUI.cpp" it's still "Align To Native" & "Align to Native - With Texture Offset". Any comment?

No it isn't.

Edit: No you're right, sorry, I missed that.

@refractionpcsx2
Copy link
Member Author

Thanks @AmyRoxwell ! Yeah I also noticed SOTC looks better with the new option, it gets rid of some side glow and stops some weird distance glitching that currently happens on master too.

@Berylskid
Copy link
Contributor

Tested Armored Core Nexus (SLPS-25338 / SLPS-25339). The new option seems closer to Software compared to master (HPO Normal).
GS Dump: Armored Core - Nexus [Disc 1]_SLPS-25338_20250225202111.gs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants