CDVD: Fix OSDSYS Audio CD regressions.

[F0bes]

Description of Changes

Fixes a regression introduced back in 2022, preventing OSDSYS from playing CD audio longer than one second.
Fixes another regression regarding SUBQ and an off-by-one in the getTOC implementation

Rationale behind Changes

Accuracy is good. Fixes the OSDSYS CD player for those who like watching that little cube spin around.
Fixes #4178

Suggested Testing Steps

Use an audio CD in OSDSYS and see if it plays music or stops after 1 second.
See if dance factory still works. EDIT: It does.

[knight-ryu12]

Mounting via actual CDVD works well; recognized CD perfectly and playback in OSDSYS works.

But there is one issue that I can't mount "split BIN+CUE" file.
seems that check of discs for game precedes before detecting as Audio discs.

[Mrlinkwii]

But there is one issue that I can't mount "split BIN+CUE" file. seems that check of discs for game precedes before detecting as Audio discs.

this pr dose not fix this you need to mount the bin cue on a virtually mounted drive , on linux use Gcdemu can do this or windows automatically

[Mrlinkwii]

tested with virtually mounted bin cue , works really well , i think most of the issues are fixed re: OSDSYS Audio CD regressions , i think this may also fix #4178

Unknown.Game_20241125121634.mp4

[StillPlay2]

But there is one issue that I can't mount "split BIN+CUE" file. seems that check of discs for game precedes before detecting as Audio discs.

this pr dose not fix this you need to mount the bin cue on a virtually mounted drive , on linux use Gcdemu can do this or windows automatically

It needs to be able to mount, and should be able to. There is some game that REQUIRES CD-Audio to be mounted (DJBox) And PS1 CD-DA games, and PS2 Multi tracked games. Which ISO won't and shouldn't cover.

PCSX2 can mount BIN+CUE, but fails to recognise files being audio, which may need to fix in preceding PR or this PR (which, I think it should qualify as a regression)

If you mean playing the .bin file directly from the .cue file then cue support hasn't been implemented yet.
In the case of Dance Factory & games with Red Book Audio, you can mount the .cue with Daemon Tools, PowerISO etc & it will read the proceeding files associated.

[knight-ryu12]

Yes I figured that out. Sorry 😔