Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize register list drawing #1079

Merged
merged 2 commits into from
Jan 3, 2016
Merged

Optimize register list drawing #1079

merged 2 commits into from
Jan 3, 2016

Conversation

Kingcom
Copy link
Contributor

@Kingcom Kingcom commented Jan 1, 2016

Only draw the rows that are actually visible. Wasn't really an issue, but it can't hurt not to draw stuff you won't see anyway.

Also takes care of @turtleli 's remark.

@Kingcom
Copy link
Contributor Author

Kingcom commented Jan 1, 2016

And fixes a recently introduced issue with the mouse position calculation... GetViewStart reports in scroll units, for whatever reason, instead of pixels.

@turtleli
Copy link
Member

turtleli commented Jan 2, 2016

Works fine.

Slight issue - Doesn't compile on Linux wx2.8 due to GetViewStart() (I think we're keeping wx2.8 compatibility on Linux until 1.4 is released)

@Kingcom
Copy link
Contributor Author

Kingcom commented Jan 2, 2016

What issue is there with GetViewStart()? As far as I can tell, it was around at the time: http://docs.wxwidgets.org/2.8.8/wx_wxscrolledwindow.html#wxscrolledwindowgetviewstart

@turtleli
Copy link
Member

turtleli commented Jan 2, 2016

Oops, didn't notice that.

Both wx2.8 and wx3.0 have void GetViewStart(int *x, int *y) but only wx3.0 also has wxPoint GetViewStart(), which is what you've used. It would probably work fine if you changed it.

@Kingcom
Copy link
Contributor Author

Kingcom commented Jan 2, 2016

Okay, updated it.

turtleli added a commit that referenced this pull request Jan 3, 2016
Optimize register list drawing
Fixes a register list GUI issue on Linux.
@turtleli turtleli merged commit f14797e into PCSX2:master Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants