Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Tourist Trophy: License Tests are broken and not completeable, player is placed out of bounds #11507

Open
wefalltomorrow opened this issue Jul 6, 2024 · 2 comments

Comments

@wefalltomorrow
Copy link

Describe the Bug

Tourist Trophy (all regions) has broken license tests making the career not completeable, video demos of the bug:

bandicam.2024-07-06.21-55-57-751.mp4
bandicam.2024-07-06.21-59-01-608.mp4

Reproduction Steps

Go to any license test inside the career mode and try and complete them, most will fail as soon as they start

Expected Behavior

Player should be placed on the correct position of the track instead of out of bounds, making the license tests playable and the career mode completeable

PCSX2 Revision

v1.7.5957

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

I7-8700

GPU

RTX 3070

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

No response

@Mrlinkwii
Copy link
Contributor

its referenced in the FPU meta here #2245 , but as per the wiki the game is still as bad as GT4 was re: clamping /rounding before GT4 was mostly fixed , so ill label this as core/ floating point accuracy

@wefalltomorrow
Copy link
Author

its referenced in the FPU meta here #2245 , but as per the wiki the game is still as bad as GT4 was re: clamping /rounding before GT4 was mostly fixed , so ill label this as core/ floating point accuracy

Ah I didn't see the FPU thread, my bad! Even following the wiki with the suggested clamping modes, the game will often freeze when loading license tests (for both regions in my experience unlike what the wiki says).

GitHubProUser67 added a commit to GitHubProUser67/pcsx2 that referenced this issue Nov 12, 2024
…int uint specification.

This Pull Request implements the first take ever on real Soft-Float support in PCSX2.

This work is a combination or several efforts and researches done prior.

Credits:

- https://www.gregorygaines.com/blog/emulating-ps2-floating-point-nums-ieee-754-diffs-part-1/

- https://github.com/GitHubProUser67/MultiServer3/blob/main/BackendServices/CastleLibrary/EmotionEngine.Emulator/Ps2Float.cs

- https://github.com/Goatman13/pcsx2/tree/accurate_int_add_sub

- PCSX2 Team for their help and support in this massive journey.

This pull request should be tested with every games requiring a clamping/rounding mode (cf: GameDatabase).

Currently, this PR fixes on the interpreters:

- PCSX2#354

- PCSX2#11507

- PCSX2#10519

- PCSX2#8068

- PCSX2#7642

- PCSX2#5257

This is important to note, that this implementation, while technically fixing Gran Turismo 4 and Klonoa 2, makes the games crash due to very high floats being passed in the emu code, and failing at some points later in the process. This has not yet been ironed-out.

Other than that, this sets the floor for Soft-Float in PCSX2, a long awaited contribution.
GitHubProUser67 added a commit to GitHubProUser67/pcsx2 that referenced this issue Nov 12, 2024
…oint unit specification.

This Pull Request implements the first take ever on real Soft-Float support in PCSX2.

This work is a combination or several efforts and researches done prior.

Credits:

- https://www.gregorygaines.com/blog/emulating-ps2-floating-point-nums-ieee-754-diffs-part-1/

- https://github.com/GitHubProUser67/MultiServer3/blob/main/BackendServices/CastleLibrary/EmotionEngine.Emulator/Ps2Float.cs

- https://github.com/Goatman13/pcsx2/tree/accurate_int_add_sub

- PCSX2 Team for their help and support in this massive journey.

This pull request should be tested with every games requiring a clamping/rounding mode (cf: GameDatabase).

Currently, this PR fixes on the interpreters:

- PCSX2#354

- PCSX2#11507

- PCSX2#10519

- PCSX2#8068

- PCSX2#7642

- PCSX2#5257

This is important to note, that this implementation, while technically fixing Gran Turismo 4 and Klonoa 2, makes the games crash due to very high floats being passed in the emu code, and failing at some points later in the process. This has not yet been ironed-out.

Other than that, this sets the floor for Soft-Float in PCSX2, a long awaited contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants