Skip to content

Commit

Permalink
ci: Stop caching submodules, no consistent way to detect changes
Browse files Browse the repository at this point in the history
There doesn't seem to be an obvious way to detect a submodule change.  If the TAG was put inside the `gitmodules` file that would be another thing, but it isn't.  So after a new submodule is added, the cache is never evicted (for instance in this PR's case, where an existing submodule is bumped to a new commit)
  • Loading branch information
xTVaser authored and lightningterror committed Mar 20, 2021
1 parent b819cfc commit af98432
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/linux-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,6 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v2

- name: Cache Submodules
id: cache-submodules
uses: actions/[email protected]
with:
key: submodules-${{ hashFiles('./.gitmodules') }}
path: |
./.git/modules/
./3rdparty/fmt
./3rdparty/xz
./3rdparty/yaml-cpp
./3rdparty/gtest
- name: Checkout Submodules
if: steps.cache-submodules.outputs.cache-hit != 'true'
run: git submodule update --init --recursive --jobs 2
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/windows-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,6 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v2

- name: Cache Submodules
id: cache-submodules
uses: actions/[email protected]
with:
key: submodules-${{ hashFiles('./.gitmodules') }}
path: |
./.git/modules/
./3rdparty/fmt
./3rdparty/xz
./3rdparty/yaml-cpp
./3rdparty/gtest
- name: Checkout Submodules
if: steps.cache-submodules.outputs.cache-hit != 'true'
run: git submodule update --init --recursive --jobs 2
Expand Down

0 comments on commit af98432

Please sign in to comment.