-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Stop caching submodules, no consistent way to detect changes
There doesn't seem to be an obvious way to detect a submodule change. If the TAG was put inside the `gitmodules` file that would be another thing, but it isn't. So after a new submodule is added, the cache is never evicted (for instance in this PR's case, where an existing submodule is bumped to a new commit)
- Loading branch information
1 parent
b819cfc
commit af98432
Showing
2 changed files
with
0 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,18 +72,6 @@ jobs: | |
- name: Checkout Repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Cache Submodules | ||
id: cache-submodules | ||
uses: actions/[email protected] | ||
with: | ||
key: submodules-${{ hashFiles('./.gitmodules') }} | ||
path: | | ||
./.git/modules/ | ||
./3rdparty/fmt | ||
./3rdparty/xz | ||
./3rdparty/yaml-cpp | ||
./3rdparty/gtest | ||
- name: Checkout Submodules | ||
if: steps.cache-submodules.outputs.cache-hit != 'true' | ||
run: git submodule update --init --recursive --jobs 2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,18 +51,6 @@ jobs: | |
- name: Checkout Repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Cache Submodules | ||
id: cache-submodules | ||
uses: actions/[email protected] | ||
with: | ||
key: submodules-${{ hashFiles('./.gitmodules') }} | ||
path: | | ||
./.git/modules/ | ||
./3rdparty/fmt | ||
./3rdparty/xz | ||
./3rdparty/yaml-cpp | ||
./3rdparty/gtest | ||
- name: Checkout Submodules | ||
if: steps.cache-submodules.outputs.cache-hit != 'true' | ||
run: git submodule update --init --recursive --jobs 2 | ||
|