Update make_extrema_longrun_3day.py

[mfwehner]

Revision by MFW 08/10/2018: Removed the 4 seasons for speed. Added some comments

[gleckler1]

@mfwehner Great, that works fine.... was not sure you had permission.

[durack1]

@mfwehner welcome to team PCMDI!

[doutriaux1]

@mfwehner a few comments

• please use the pmpparser instead of sys.argv.
• add a test
• use autopep8 and flake8 for code niceness

If you need help with any of this just let me know.

[mfwehner]

Charles I need help on these. Examples would be all I need. michael

On Aug 20, 2018, at 6:10 AM, Charles Doutriaux ***@***.***> wrote: @mfwehner <https://github.com/mfwehner> a few comments please use the pmpparser instead of sys.argv. add a test use autopep8 and flake8 for code niceness If you need help with any of this just let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#567 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKShHHFtKjCPfvlAFQU4f-4UPjGnpiKxks5uSrVMgaJpZM4V4sQM>.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Michael Wehner [email protected] https://crd.lbl.gov/departments/computational-science/ccmc/staff/staff-members/michael-wehner/ Senior Staff Scientist, Lawrence Berkeley National Laboratory US DOE Policy 411.2A: When expressing opinions on policy matters to the public and media, research personnel must make it clear when they are expressing their personal views, rather than those of the Department, the U.S. Government, or their respective institutions. Public representation of Government or DOE positions or policies must be cleared through their program management to include DOE headquarters. In accordance with this policy, any material in this email should be considered the opinion of the sender and not necessarily that of the US Dept. of Energy, the University of California or the Lawrence Berkeley National Laboratory.

[doutriaux1]

@mfwehner ok I will write a notebook about this and add it to the doc (developer) it is a nice addition. will post link here as well.

[doutriaux1]

@gleckler1 we might already have pmp parser examples as part of cia can you post the link please?

[gleckler1]

@mfwehner @doutriaux1 We need to think about the best use of MFW's time. I am already working with his make_extrema_longrun_3day.py and pentadal scripts which are working but very slow. CD, MFW is not familiar with python dictionaries and other functionality we heavily rely on. We can't expect him to be able to follow our param file and agrparse conventions until we have that thoroughly documented. That is not going to be available until mid September. PG checking out on 2wk VAC this Weds, 8/22.

[doutriaux1]

@gleckler1 ok. @mfwehner I can review your additions in the mean time.

[mfwehner]

On Aug 20, 2018, at 9:36 AM, gleckler1 ***@***.***> wrote: PG checking out on 2wk VAC this Weds, 8/22.

Have fun! I was going to upload the MPI hurricane diagnostic code but NERSC is down until Wednesday for power system upgrades. That code runs off of monthly means, so speed should not be an issue. Also, I will try and determine some throughput speeds at NERSC for the annual daily maximum code when it returns. Michael PS. How do you reply via the github? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Michael Wehner [email protected] https://crd.lbl.gov/departments/computational-science/ccmc/staff/staff-members/michael-wehner/ Senior Staff Scientist, Lawrence Berkeley National Laboratory US DOE Policy 411.2A: When expressing opinions on policy matters to the public and media, research personnel must make it clear when they are expressing their personal views, rather than those of the Department, the U.S. Government, or their respective institutions. Public representation of Government or DOE positions or policies must be cleared through their program management to include DOE headquarters. In accordance with this policy, any material in this email should be considered the opinion of the sender and not necessarily that of the US Dept. of Energy, the University of California or the Lawrence Berkeley National Laboratory.

[durack1]

@mfwehner you just did, by replying to email - although it's cleaner to reply to the issue thread (less cruft)