-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo8 extremes update #1013
Demo8 extremes update #1013
Conversation
lee1043
commented
Dec 23, 2023
•
edited
Loading
edited
- Reduced number of lines (in cell [3])
- Clean up notebook
- Result from latest rerun
@acordonez Thank you for resolving the issues for the extreme PR. I was able to make Demo8 notebook run it through. I opened this PR for a few edits in the Demo8 notebook and also for some questions.
|
Regarding 1., the figure looks pretty similar to me once you account for the change in the colorbar. Unfortunately I don't think the various fits and solvers used to get the return values are guaranteed to produce stable results, but I'll look into this some more. |
Regarding 2., I've tried a couple of ways to suppress warnings in the Jupyter notebook but have not been successful. I've tried the warnings module and the %%capture cell magic, but in both cases I still see all the warnings. I'm reluctant to turn off all the warnings within the driver itself, as they are flagging real instances where the GEV fit is failing for one reason or another. Do you have any other suggestions? |
Here's the return value results I got for the first test run in the Demo, and I'm getting slightly different results from you and from my original run - not much matches after the decimal point. It wasn't unusual for me to get different results when I was testing the code on single timeseries, so I'm not surprised.
|
@acordonez thank you for the comments. I think we can be confident merging this if differences are only at decimal point level. |