使 BanHandlerNormal 复用原本的 setBanListIncrement 和 setBanListFull 逻辑

[paulzzh]

Summary by CodeRabbit

• New Features
  • Improved dependency management for the BanHandlerNormal class, simplifying its instantiation.
• Bug Fixes
  • Enhanced error handling and logging mechanisms for ban list management.
• Documentation
  • Added @Override annotation to the saveToYaml method for better clarity and compliance.

[coderabbitai]

Walkthrough

The changes involve refactoring the BanHandlerNormal class within the QBittorrentEE.java file to improve dependency management by passing a single QBittorrentEE instance to its constructor. This allows for better access to necessary data and reduces code duplication by delegating ban list handling to methods in QBittorrentEE. Additionally, an @Override annotation was added to the saveToYaml method in the QBittorrentEEConfigImpl class to clarify its relationship with the parent class or interface.

Changes

File Path	Change Summary
src/main/java/com/ghostchu/peerbanhelper/downloader/impl/qbittorrent/...	Refactored BanHandlerNormal to accept QBittorrentEE instance in constructor; methods for ban list handling now delegate to QBittorrentEE.
src/main/java/com/ghostchu/peerbanhelper/downloader/impl/qbittorrent/...	Added @Override annotation to saveToYaml method in QBittorrentEEConfigImpl.

Possibly related PRs

• 重写 shadowBan 支持检测 & 修复 qb 登录状态检测 #445: This PR enhances the login functionality and shadow ban checks in QBittorrentEE.java, which is related to the refactoring of the BanHandlerNormal class.

Poem

In the code where rabbits hop,
Refactoring makes the old things stop.
With QBittorrentEE by its side,
BanHandlerNormal takes a smoother ride.
Methods now dance, less clutter in sight,
Hooray for changes, oh what a delight! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 177d6dc and 7e82ac4.

Files selected for processing (1)

• src/main/java/com/ghostchu/peerbanhelper/downloader/impl/qbittorrent/impl/enhanced/QBittorrentEE.java (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/main/java/com/ghostchu/peerbanhelper/downloader/impl/qbittorrent/impl/enhanced/QBittorrentEE.java

Additional context used

Learnings (1)

Common learnings

Learnt from: Ghost-chu
PR: PBH-BTN/PeerBanHelper#400
File: src/main/java/com/ghostchu/peerbanhelper/downloader/impl/qbittorrent/QBittorrentEE.java:134-142
Timestamp: 2024-08-30T18:57:41.277Z
Learning: Ghost-chu prefers not to receive logging suggestions in code reviews.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Ghost-chu]

YOLO