Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYOSWXP-156: set transaction-state to „authorized“ on „appointed“ #329

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

rommelfreddy
Copy link
Collaborator

please do not squash

@rommelfreddy rommelfreddy force-pushed the task/PAYOSWXP-156_add-authorize-state branch from 7f10d49 to 4b7fe0b Compare September 13, 2024 12:56
@rommelfreddy rommelfreddy force-pushed the task/PAYOSWXP-156_add-authorize-state branch from 4b7fe0b to da14951 Compare September 13, 2024 15:07

public function supports(SalesChannelContext $salesChannelContext, array $data): bool
{
return isset($data['txid']) && ($data['txaction'] ?? null) === 'appointed';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the constant TransactionStatusService::ACTION_APPOINTED instead of 'appointed'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. i added the constant.

@rommelfreddy rommelfreddy force-pushed the task/PAYOSWXP-156_add-authorize-state branch from da14951 to 1e26985 Compare September 16, 2024 07:53
@janteuber janteuber self-requested a review September 23, 2024 13:21
@janteuber janteuber merged commit de976c1 into master Sep 23, 2024
14 checks passed
@janteuber janteuber deleted the task/PAYOSWXP-156_add-authorize-state branch September 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants