PAYOSWXP-120: Adds new log feature: Notification Forward logs are now saved in payone_transaction_forward #288
Conversation
amirinterlutions
force-pushed
the
task/PAYOSWXP-120_PAYOSWXP-121
branch
from
1312097 to
213a189
Compare
src/Payone/Webhook/MessageBus/MessageHandler/NotificationForwardHandler.php
Show resolved
Hide resolved
| @@ -71,10 +81,10 @@ private function getNotificationForwards(array $ids, Context $context): EntitySe | |||
| } | |||
|
|
|||
| private function updateResponses( | |||
| \CurlMultiHandle $multiHandle, | |||
| \CurlMultiHandle $multiHandle, | |||
There was a problem hiding this comment.
please remove this formatting
There was a problem hiding this comment.
I think I used the Easy Code Standard from Payone. I should take another look to understand why it wasn't corrected.
| { | ||
| $statusCode = $responseInfo['http_code']; | ||
|
|
||
| $response = new Response($responseContent, $statusCode, $responseInfo); |
There was a problem hiding this comment.
good idea to check with the Response-Object if the method is successfully & get the response text.
but it would make more sense to check if the HTTP status is greater than 200 & lower than 300.
All 20x status means that the response is successfully.
I like the idea to get the status text. But please use the status text from the http Header status.
I am not sure, but maybe you can get the status text also from the curl-info object.
There was a problem hiding this comment.
Thanks! Yes, I tried to structure it a bit. There's a method isSuccessful() that specifically checks if the HTTP code is between 200 and 300 (as you prefer). I used it to log the correct status ($loglevel) for all statuses.
All curl-info looks like this:
{
"url": "https://payoswxp.ngrok.io/simple-my-webhook-notif.php",
"content_type": "text/html; charset=UTF-8",
"http_code": 200,
"header_size": 197,
"request_size": 163,
"filetime": -1,
"ssl_verify_result": 0,
"redirect_count": 0,
"total_time": 0.107368,
"namelookup_time": 0.00117,
"connect_time": 0.019795,
"pretransfer_time": 0.046854,
"size_upload": 469.0,
"size_download": 28.0,
"speed_download": 261.0,
"speed_upload": 4383.0,
"download_content_length": -1.0,
"upload_content_length": 469.0,
"starttransfer_time": 0.0469,
"redirect_time": 0.0,
"redirect_url": "",
"primary_ip": "3.125.102.39",
"certinfo": [],
"primary_port": 443,
"local_ip": "172.21.0.2",
"local_port": 54576,
"http_version": 3,
"protocol": 2,
"ssl_verifyresult": 0,
"scheme": "HTTPS",
"appconnect_time_us": 46726,
"connect_time_us": 19795,
"namelookup_time_us": 1170,
"pretransfer_time_us": 46854,
"redirect_time_us": 0,
"starttransfer_time_us": 46900,
"total_time_us": 107368
}There are actually no status texts, so I used text from Response::$statusTexts.
There was a problem hiding this comment.
I corrected the branch name, and further commits are here.
PAYOSWXP-120 → #290
| @@ -136,7 +148,7 @@ private function getForwardRequests(\CurlMultiHandle $multiHandle, EntitySearchR | |||
|
|
|||
| private function buildHeaders( | |||
| PayonePaymentNotificationForwardEntity $forward, | |||
| PayonePaymentNotificationTargetEntity $target | |||
| PayonePaymentNotificationTargetEntity $target | |||
There was a problem hiding this comment.
please remove this formatting
src/Payone/Webhook/MessageBus/MessageHandler/NotificationForwardHandler.php
Show resolved
Hide resolved
rommelfreddy
changed the title
…e of sending notifications to a URL. Adds new log feature: Notification Forward logs are now saved in .
rommelfreddy
force-pushed
the
task/PAYOSWXP-120_PAYOSWXP-121
branch
from
59c6b08 to
3b5f4b8
Compare
|
continue in #290 |
PAYOSWXP-120: Adds new log feature: Notification Forward logs are now saved in
payone_transaction_forwardPAYOSWXP-121: Fixes Notification Forward: Now capable of sending notifications to a URL.