Fixes that by default all payment methods were active and disabled by proactive entries in core_config_data
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proactive entries in `core_config_data` Disabling payment methods via `core_config_data` prevents activation via `config.xml`. Instead all payment methods should be disabled by default via `config.xml`, thus allowing integrators to selectively enabling them via their own `config.xml`. Additionally the fields should be defined to be restorable, thus preventing default values from being stored in `core_config_data` when someone configures entries in the Magento backend. These two issues are solved by this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues:
core_config_dataprevents activation viaconfig.xml. Instead all payment methods should be disabled by default viaconfig.xml, thus allowing integrators to selectively enabling them via their ownconfig.xml.core_config_datawhen someone configures entries in the Magento backend. This helps keep the data stored incore_config_dataminimal and thus maintainable