Merge pull request #2 from PAYONE-GmbH/develop · PAYONE-GmbH/PCP-ServerSDK-DotNet@19a3594

Triggered via push September 2, 2024 10:23

Blackfaded

main

Status Success

Total duration 2m 13s

Artifacts –

lint_test_sonar.yml

on: push

Matrix: test

10 warnings

sonar: lib/PCPServerSDKDotNet/Utils/ServerMetaInfo.cs#L6

Implement 'IEquatable<ServerMetaInfo>'. (https://rules.sonarsource.com/csharp/RSPEC-3897)

sonar: lib/PCPServerSDKDotNet/Utils/ServerMetaInfo.cs#L6

Seal class 'ServerMetaInfo' or implement 'IEqualityComparer<T>' instead. (https://rules.sonarsource.com/csharp/RSPEC-4035)

sonar: lib/PCPServerSDKDotNet/Models/APIError.cs#L12

Rename class 'APIError' to match pascal case naming rules, consider using 'ApiError'. (https://rules.sonarsource.com/csharp/RSPEC-101)

sonar: lib/PCPServerSDKDotNet/Models/applepay/ApplePayPaymentContact.cs#L9

Seal class 'ApplePayPaymentContact' or implement 'IEqualityComparer<T>' instead. (https://rules.sonarsource.com/csharp/RSPEC-4035)

sonar: lib/PCPServerSDKDotNet/Models/Network.cs#L7

Rename this enumeration to remove the 'Enum' suffix. (https://rules.sonarsource.com/csharp/RSPEC-2344)

sonar: lib/PCPServerSDKDotNet/Utils/ServerMetaInfo.cs#L60

Replace this type-check-and-cast sequence to use pattern matching. (https://rules.sonarsource.com/csharp/RSPEC-3247)

sonar: lib/PCPServerSDKDotNet/Transformer/ApplePayTransformer.cs#L31

Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589)

sonar: lib/PCPServerSDKDotNet/Transformer/ApplePayTransformer.cs#L37

Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589)

sonar: lib/PCPServerSDKDotNet/Transformer/ApplePayTransformer.cs#L45

Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589)

sonar: lib/PCPServerSDKDotNet/RequestHeaderGenerator.cs#L60

Make 'GetStringToSign' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)