Skip to content

Commit

Permalink
fix(carousel): fix @past3lle/carousel type bug (#106)
Browse files Browse the repository at this point in the history
* fix(carousel): use data.length not global length

* chore: use yarn 4 w/ node_modules

- yarn files
- remove glob resolutions from packages

* chore: ignore .yarn

* chore: lint

* chore: format

* chore: remove .yarn

* chore: add .yarn folder

* chore: format

* chore: update github workflow scripts

* chore: format

* chore: update .prettierignore

* chore: format

* chore: update .gitignore and remove install-state

---------

Co-authored-by: W3stside <[email protected]>
  • Loading branch information
W3stside and W3stside authored Sep 28, 2024
1 parent 2a65688 commit 3106674
Show file tree
Hide file tree
Showing 19 changed files with 33,321 additions and 23,873 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
clean: true

- name: Install dependencies
run: yarn install --frozen-lockfile
run: yarn install --immutable

- name: Build packages
# skip building apps
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v4

- name: Install dependencies
run: yarn install --frozen-lockfile
run: yarn install --immutable

- name: Lint code
run: yarn lint
Expand All @@ -38,7 +38,7 @@ jobs:
uses: actions/checkout@v4

- name: Install dependencies
run: yarn install --frozen-lockfile
run: yarn install --immutable

- name: Build
run: yarn build:packages
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ coverage
/example/gatsby-example/
/example/.parcel-cache
/example/.cache
*.tgz
.yarn/*
!.yarn/releases
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
.DS_Store

node_modules
.yarn

.parcel-cache
.cache
Expand All @@ -27,6 +28,7 @@ tsconfig.json
tsconfig.*.json
tsconfig.tsbuildinfo
version.json
*.gz

.eslintrc.json

Expand Down
925 changes: 925 additions & 0 deletions .yarn/releases/yarn-4.5.0.cjs

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions .yarnrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1


yarn-path ".yarn/releases/yarn-1.22.22.cjs"
2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
yarnPath: .yarn/releases/yarn-4.5.0.cjs
nodeLinker: node-modules
15 changes: 6 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,35 +41,32 @@
"version:update": "node scripts/updateVersions.mjs"
},
"devDependencies": {
"@babel/cli": "^7.20.7",
"@babel/preset-env": "^7.20.2",
"@babel/preset-typescript": "^7.18.6",
"@trivago/prettier-plugin-sort-imports": "^4.0.0",
"@types/jest": "^29.4.0",
"@typescript-eslint/eslint-plugin": "^5.48.2",
"@typescript-eslint/parser": "^5.48.2",
"glob": "^10.3.10",
"eslint": "^8.32.0",
"eslint-config-prettier": "^8.6.0",
"eslint-plugin-prettier": "^4.2.1",
"glob": "^10.3.10",
"is-ci": "^3.0.1",
"jest": "^29.4.0",
"lerna": "^6.4.1",
"prettier": "^2.8.3",
"ts-jest": "^29.0.5",
"typescript": "^5.2.2",
"@babel/cli": "^7.20.7",
"@babel/preset-env": "^7.20.2"
"typescript": "^5.2.2"
},
"dependencies": {},
"resolutions": {
"@tanstack/react-query": "^5.x",
"**/*/@tanstack/react-query": "^5.x",
"**/*/viem": ">=2.10.0 < 3",
"viem": ">=2.10.0 < 3",
"**/*/wagmi": ">=2.5.5 < 3",
"wagmi": ">=2.5.5 < 3"
},
"workspaces": [
"packages/*",
"apps/*"
]
],
"packageManager": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/carousel/src/components/ButtonCarousel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export default function ButtonCarousel<D extends any[]>({
onPrev={onPrevious}
onNext={onNext}
>
{children({ index, defaultImageTransforms, isLast: index === length - 1 })}
{children({ index, defaultImageTransforms, isLast: index === data.length - 1 })}
</CarouselItem>
)
})}
Expand Down
4 changes: 1 addition & 3 deletions packages/forge-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
"author": "pastelle",
"homepage": "https://github.com/past3lle/monorepo/tree/main/packages/forge-cli#readme",
"license": "MIT",
"bin": {
"forge-cli": "./bin/forge-cli.js"
},
"bin": "./bin/forge-cli.js",
"type": "commonjs",
"main": "dist/index.js",
"module": "dist/forge-cli.esm.js",
Expand Down
3 changes: 0 additions & 3 deletions packages/forge-web3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,7 @@
"wagmi": "^2.12.8"
},
"resolutions": {
"**/*/@tanstack/react-query": "^5.x",
"**/*/viem": ">=2.10.0 < 3",
"viem": ">=2.10.0 < 3",
"**/*/wagmi": ">=2.5.5 < 3",
"wagmi": ">=2.5.5 < 3"
},
"browserslist": {
Expand Down
3 changes: 0 additions & 3 deletions packages/skillforge-widget/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,7 @@
"polished": "^4.2.2"
},
"resolutions": {
"**/*/@tanstack/react-query": "^5.x",
"**/*/viem": ">=2.10.0 < 3",
"viem": ">=2.10.0 < 3",
"**/*/wagmi": ">=2.5.5 < 3",
"wagmi": ">=2.5.5 < 3"
},
"bugs": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export function ActiveSkillPanel() {
deps: activeSkill?.properties?.dependencies || [],
get cardColour() {
return isLocked
? 'black' || baseTheme.gradients.lockedSkill
? baseTheme.gradients.lockedSkill || BLACK
: this.rarity
? baseTheme.gradients.unlockedSkill + `${customTheme.rarity[this.rarity].backgroundColor})`
: null
Expand Down
3 changes: 0 additions & 3 deletions packages/wagmi-connectors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@
"wagmi": "^2.12.8"
},
"resolutions": {
"**/*/@tanstack/react-query": "^5.x",
"**/*/viem": ">=2.10.0 < 3",
"viem": ">=2.10.0 < 3",
"**/*/wagmi": ">=2.5.5 < 3",
"wagmi": ">=2.5.5 < 3"
},
"browserslist": {
Expand Down
3 changes: 0 additions & 3 deletions packages/web3-modal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,8 @@
"wagmi": ">=2.5.5 < 3"
},
"resolutions": {
"**/*/@tanstack/react-query": "^5.x",
"@tanstack/react-query": "^5.x",
"**/*/viem": ">=2.10.0 < 3",
"viem": ">=2.10.0 < 3",
"**/*/wagmi": ">=2.5.5 < 3",
"wagmi": ">=2.5.5 < 3",
"styled-components": "^5.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-modal/src/fixtures/connectorsAndPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const INJECTED_CONNECTORS = [
if (IS_SERVER) return undefined
try {
const provider = window?.tally
if (!provider) devWarn('Connector', 'Taho' || 'unknown', 'not found!')
if (!provider) devWarn('Connector', 'Taho', 'not found!')
return provider
} catch (error) {
return undefined
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-modal/src/hooks/misc/useTimeout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function useTimeoutClearingError(
}, [error, time])

const resetError = useCallback(() => {
clearTimeout(timeout)
if (timeout) clearTimeout(timeout)
setShowError(false)
callback?.(null)
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-modal/src/theme/baseTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export const PstlModalTheme: ThemeByModes<PstlModalThemeExtension> = {
font: {
color: 'ghostwhite'
},
background: 'black' || '#000000de'
background: 'black' // was --> || '#000000de'
},
helpers: {
show: true,
Expand Down
Loading

0 comments on commit 3106674

Please sign in to comment.