fix: regression for handling whitespaces in args #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fix a regression for the handling of whitespaces in command arguments. According to the documentation for `spawn`, the arguments don't need to be enquoted beforehand, and doing so actually breaks the support for whitespaces.
P403n1x87
force-pushed
the
fix/spaces-in-args
branch
from
a0680b1 to
4a14944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix a regression for the handling of whitespaces in command arguments. According to the documentation for
spawn, the arguments don't need to be enquoted beforehand, and doing so actually breaks the support for whitespaces.Fixes #42 #62 #64