fix: correct units for memory metrics #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah another well spotted issue! I think this was not changed when I finally settled for reporting bytes from Austin. I have just double-checked and indeed Austin reports bytes, so this should definitely be |
P403n1x87
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 16 16
Lines 1508 1508
Branches 218 218
=======================================
Hits 1117 1117
Misses 328 328
Partials 63 63 ☔ View full report in Codecov by Sentry. |
|
Fab! Seems to be all green now 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28 (unless I've misunderstood in which case this may be nonsense sorry... but I hope not!)
As described in the issue, I believe the value here is always bytes, it's just the type name which is confusing.