Hot-reload using webpack 5 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvesmiguel1
reviewed
Nov 2, 2023
joaompneves
reviewed
Nov 2, 2023
alvesmiguel1
approved these changes
Nov 13, 2023
|
Ready for review, all tests are passing |
alvesmiguel1
force-pushed
the
chore/hot-reload-fixes
branch
from
e3d9db5 to
36bf792
Compare
cc @joaompneves |
joaompneves
reviewed
Dec 6, 2023
|
@joaompneves you might take a new look to the changes performed |
|
Adding @tbragaf to the code review since Neves is on vacations |
tbragaf
approved these changes
Dec 13, 2023
joaompneves
reviewed
Jan 2, 2024
| @@ -0,0 +1,14 @@ | |||
| namespace ReactViewControl; | |||
|
|
|||
| public class ModuleDependenciesProviderFactory : IModuleDependenciesProviderFactory { | |||
Comment on lines
+7
to
+9
| public static void SetInstance(IModuleDependenciesProviderFactory factory) { | ||
| Instance = factory; | ||
| } |
|
|
||
| public class ModuleDependenciesProviderFactory : IModuleDependenciesProviderFactory { | ||
|
|
||
| public static IModuleDependenciesProviderFactory Instance { get; private set; } = new ModuleDependenciesProviderFactory(); |
There was a problem hiding this comment.
public static IModuleDependenciesProviderFactory Instance { get; set; } = new ModuleDependenciesProviderFactory();
| Instance = factory; | ||
| } | ||
|
|
||
| public virtual IModuleDependenciesProvider CreateModuleDependenciesProvider(string sourcePath) { |
There was a problem hiding this comment.
public IModuleDependenciesProvider CreateModuleDependenciesProvider(string sourcePath) {
|
Hey @joaompneves , I will tackle your review in a PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.