Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to aggregate.py #486

Merged
merged 14 commits into from
Nov 4, 2024
Merged

Add tests to aggregate.py #486

merged 14 commits into from
Nov 4, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Nov 1, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Mainly, this adds tests to the lines in aggregate.py that had yet to be tested.
  • Bugfix: climatological_op now correctly handles kwargs.
  • Bugfix: climatological_op with linregress now correctly handles min_periods
  • Removed obsolete code now that we pin xarray >=2023.11.
  • Bugfix: datablock_3d did not use the same attributes for the rotated pole when creating the fake dataset.

Does this PR introduce a breaking change?

  • method=='interp_centroid' in spatial_mean has been removed without backwards compatibility or staged removal, since it could produce vastly erroneous results.
  • Not really breaking since the function was not public, but regrid._get_grid_mapping was moved to spatial.py and made public.

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RondeauG RondeauG merged commit c5a3261 into main Nov 4, 2024
16 checks passed
@RondeauG RondeauG deleted the moar_tests branch November 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants