Skip dirs in parse_directory #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
added a commit
that referenced
this pull request
Oct 21, 2024
<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [ ] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.
### What kind of change does this PR introduce?
Small fix upon #478. Skips even if a directory to skip is one of the
entries in `directory` or a parent of one of the entries.
I implemented it because I misunderstood an error I was having, but
still, this could be used in the specific scenario where you are running
`parse_directory` through an incremental stack of xscen configurations.
To remove en entry of the `directories` list of a previous
configuration, you would only need to add a `skip_dirs` entry, and not
rewrite the filtered `directories`.
This also adds logging calls when skipping. And a precision to the doc
about the absoluteness of paths to skip.
### Does this PR introduce a breaking change?
No.
### Other information:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
parse_directory: New argumentskip_dirs, a list of folders to not go into when parsing.Does this PR introduce a breaking change?
No.
Other information:
The MRCC5 catalog (him again) has two issues this help fix:
directoriesto parse. This is because I want to give some time to people to adapt to the new disk. The entries are exactly the same except for the path, so there's no way to filter them out currently with the other arguments ofparse_directory.