Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last deprecated calendar functions - adapt to xclim's main #465

Merged
merged 10 commits into from
Sep 20, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Sep 19, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Remove references to convert_calendar (removed from xclim > 0.52.2)
  • Remove references to get_calendar (not removed but using xarray is better)
  • Fix issues with the move of VARIABLES and ValidationError within xclim.
  • Make test runnable with new testdata stuff. Not tested, of course.

Does this PR introduce a breaking change?

No.

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre Zeitsperre changed the title Remove last deprecated calendar functions - adapt to xclim's master Remove last deprecated calendar functions - adapt to xclim's main Sep 19, 2024
@aulemahal aulemahal merged commit 1c40100 into main Sep 20, 2024
16 checks passed
@aulemahal aulemahal deleted the adapt-xclim-0.52 branch September 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants