Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that chunking is respected #379

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Ensure that chunking is respected #379

merged 3 commits into from
Apr 11, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Apr 8, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • original_shape and chunksizes don't play well together. This PR makes sure that original_shape is always removed before saving a dataset.
  • Also, (maybe new in the latest version of xarray and engine netcdf4?), it appears that dropping chunksizes leads to unexpected behaviours, such as bloated file size and incorrect chunking on disk. Thus, the chunksizes encoding was made more explicit.

Does this PR introduce a breaking change?

  • No.

Other information:

Related Issues:
pydata/xarray#8385
pydata/xarray#8062

@RondeauG RondeauG added the bug Something isn't working label Apr 8, 2024
@RondeauG RondeauG merged commit 65faf07 into main Apr 11, 2024
23 checks passed
@RondeauG RondeauG deleted the fix_encoding branch April 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants