Make xscen.utils.change_units() update unit name on equal units #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_units when units are physically equal but have different names (e.g. degC <-> ˚C)
Zeitsperre
approved these changes
Mar 28, 2024
juliettelavoie
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make xscen.utils.change_units() update unit name on equal units
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
During unit conversion
xscen.utils.change_unitswill adopt the name from thevariables_and_unitsdictionary if the physical units are equal but their names are not (ex. degC <-> ˚C)Useful for harmonizing unit names when processing datasets of varying origin.
Does this PR introduce a breaking change?
No.
Other information:
There is no testing for xscen.utils (yet). Right?