-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make xESMF optional #337
Make xESMF optional #337
Conversation
Yes ça marche! Issue with Python 3.9 is because of the latest conda package of intake-esm. They dropped 3.9 but the conda recipe didn't know about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this will make things much easier.
CI fails because the misconfigured conda package still exists in mamba's cache and in the conda-forge repo. But it did pass when I pinned intake-esm. Coverage for Pypi runs are decreased, which is normal since we don't test any function using xesmf. But the conda converage is stable. @Zeitsperre , what should we do ? Accept the decrease ? Stop reporting coverage for those tests ? But otherwise, this PR is good to go. |
I think accepting the one-time decrease is fine. So long as the overall coverage doesn't go down ( |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.
Other information:
@Zeitsperre I may have been heavy handed in editing the workflow and tox configuration. My idea was that the "test-pypi" didn't need xesmf/esmf anymore and so I removed any mention of it and of mamba/conda. So it can really be a "test-pypi" ci.