-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fail because of Linkcheck, add ignored links #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! thanks !
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
It looks like your latest notebook is failing. Shall I leave the fix up to you here? |
Woups, this notebook is not supposed to run. I'll deactivate it. I kept it in the repo to show how the results were obtained, and to make it easy to manually update the timeseries, periodically. But it makes reference to data inside ouranos and this link for NOAA's dataset changes each month. |
@Zeitsperre I added the "NO_COLOR" env var to the admin panel of RTD, should make the online output easier to read! Otherwise, the only warning I can find in the last build is coming from Clisops... Or I missed something else ? |
The final warning in the docs build is coming from the fact that the notebook is not explicitly ignored. ( |
Oh I see! Thanks! |
Errors are finally all addressed. I've restructured the notebooks for flow; If this isn't what we want, I can revert the changes. |
Co-authored-by: Pascal Bourgault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.