-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics.health_checks #238
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
# Conflicts: # HISTORY.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Très complète et utile fonction.
Plusieurs commentaires, mais ce sont surtout des suggestions pour simplifier.
Co-authored-by: Pascal Bourgault <[email protected]> Co-authored-by: juliettelavoie <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Pascal Bourgault <[email protected]>
Co-authored-by: Pascal Bourgault <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I should have answered all comments. Did you want to check again before we merge? |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
diagnostics.health_checks
that performs a bunch of checkups on a dataset.return_flags=True
to retrieve the dataset created by xclim'sdata_flags
(as long as the function does not raise an Exception elsewhere).datablock_3d
when the grid is not regular.Does this PR introduce a breaking change?
diagnostics.fix_unphysical_values
, although I seriously doubt that anyone was using it.Other information: