-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter build_path / better end_of_period #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
reviewed
Aug 14, 2023
RondeauG
reviewed
Aug 14, 2023
Co-authored-by: RondeauG <[email protected]>
RondeauG
reviewed
Aug 14, 2023
juliettelavoie
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't think a strict =False option is necessary.. Users can always pass their own schema.
Co-authored-by: juliettelavoie <[email protected]> Co-authored-by: RondeauG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Two different things, but that I both realized when updating the catalogs.
Stricter build_path
When I migrated from miranda, I relaxed the "structure" code because it felt too restricting and I wanted to simplify the logic. However, this wasn't a good idea. When moving the ESPO-R5-E5L indicators, I forgot to include the "experiment" field somewhere and used build_path to copy the files. Result : one scenario overwrote the other, I lost half of the data.
This PR changes the things a bit, the main change being : All facets, except those marked optional, are necessary.
build_path
will FAIL if any is missing.And:
_get_needed_fields
without the funcky magic needed before.strict=True
was overly strict because of caveats of_get_needed_fields
. Those are now fixed andstrict=False
shouldn't be needed.Better end_of_period
When I updated pandas to 2, I modified
date_parser
and it changed how the "end_of_period" was handled.Thus, when searching for a coverage, the error due to the hour of the period end will be reduced.
Does this PR introduce a breaking change?
build_path
is now always strict.Other information:
Do you agree?
I could re-implement
strict=False
if needed. It would mark all fields as optional on-the-fly. The default would stay "True".