unstack horizon #203
Merged
unstack horizon #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
approved these changes
Jun 1, 2023
| @@ -150,6 +150,7 @@ def climatological_mean( | |||
| ] | |||
| else: | |||
| raise ValueError("The type of 'time' could not be understood.") | |||
| ds_rolling = ds_rolling.drop_vars({"month", "year", "time", "day"}) | |||
There was a problem hiding this comment.
I'm guessing this is to resolve the warning that keeps popping up ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
produce_horizon#202number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
new_coords['horizon']was still the length of the original time dimension. I guess before xarray was able to make it fit with the newtimedimension, but it doesn't seem to work anymore. I manually unstackhorizonsimilarly to the variables.climatological_meanto address a future warning (FutureWarning: Updating MultiIndexed coordinate 'time' would corrupt indices for other variables: ['year', 'month', 'day']. This will raise an error in the future. Use.drop_vars({'month', 'year', 'time', 'day'})before assigning new coordinate values.)Does this PR introduce a breaking change?
no
Other information: