sdba - Fix DQM and QDM, refactor adjustment objects #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huard
requested changes
May 12, 2020
Co-authored-by: David Huard <[email protected]>
Pull Request Test Coverage Report for Build 1864
💛 - Coveralls |
aulemahal
changed the title
|
Merged fixes for QDM in this PR to save time. Dask-arrays needed a new version of |
huard
approved these changes
May 13, 2020
| @@ -37,13 +37,17 @@ | |||
| - preprocessing on `ref`, `hist` and `sim` (using methods in `xclim.sdba.processing` or `xclim.sdba.detrending`) | |||
| - creating the adjustment object `Adj = Adjustment(**kwargs)` (from `xclim.sdba.adjustment`) | |||
| - training `Adj.train(obs, sim)` | |||
| - adjustment `scen = Adj.adjust(sim)` | |||
| - adjustment with corresponding arguments `scen = Adj.adjust(sim, **kwargs)` | |||
There was a problem hiding this comment.
Suggested change
| - adjustment with corresponding arguments `scen = Adj.adjust(sim, **kwargs)` | |
| - adjustment `scen = Adj.adjust(sim, **kwargs)` |
| - post-processing on `scen` (for example: re-trending) | ||
|
|
||
| The train-adjust approach allows to inspect the trained adjustment object. The adjustment information is stored in | ||
| The train-adjust approach allows to inspect the trained adjustment object. The trained information is stored in |
There was a problem hiding this comment.
Suggested change
| The train-adjust approach allows to inspect the trained adjustment object. The trained information is stored in | |
| The train-adjust approach allows to inspect the trained adjustment object. The training information is stored in |
| @@ -127,17 +132,22 @@ class EmpiricalQuantileMapping(BaseAdjustment): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| At init: | |||
There was a problem hiding this comment.
Suggested change
| At init: | |
| At instantiation: |
| group : Union[str, Grouper] | ||
| The grouping information. See :py:class:`xclim.sdba.base.Grouper` for details. | ||
|
|
||
| In adjust: |
There was a problem hiding this comment.
Suggested change
| In adjust: | |
| In adjustment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)has been called on this branchgit push --tags)Fixes #441 by adding a grouped normalization before the detrending in DQM.
Does this PR introduce a breaking change?
No, but the behavior is not exactly what a user could expect from reading Cannon et al. 2015, a note is added in the docs to clarify this.
Other information: