Remove references to FlyingPigeon and other deprecated/unused components #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Zeitsperre
approved these changes
Jul 4, 2023
huard
commented
Jul 6, 2023
tlvu
added a commit
that referenced
this pull request
Jul 21, 2023
Most probably due to PR #296 Fix Jenkins failure: ``` _______ pavics-sdi-master/docs/source/notebooks/subsetting.ipynb::Cell 4 _______ Notebook cell execution failed Cell 4: Cell outputs differ Input: res = resp.get() print("URL: ", res.output) res = resp.get(asobj=True) res.output Traceback: mismatch 'stdout' assert reference_output == test_output failed: 'URL: https:...0612_sub.nc\n' == 'URL: https:...612_sub.nc.\n' Skipping 92 identical leading characters in diff, use -v to show 612_sub.nc - Downloading to /tmp/tmpRANDOM/tasmax_amon_mpi_esm_mr_rcp45_r1i1p1_200601_200612_sub.nc. ```
tlvu
added a commit
that referenced
this pull request
Jul 27, 2023
Most probably due to PR #296 Fix Jenkins failure: ``` _______ pavics-sdi-master/docs/source/notebooks/subsetting.ipynb::Cell 4 _______ Notebook cell execution failed Cell 4: Cell outputs differ Input: res = resp.get() print("URL: ", res.output) res = resp.get(asobj=True) res.output Traceback: mismatch 'stdout' assert reference_output == test_output failed: 'URL: https:...0612_sub.nc\n' == 'URL: https:...612_sub.nc.\n' Skipping 92 identical leading characters in diff, use -v to show 612_sub.nc - Downloading to /tmp/tmpRANDOM/tasmax_amon_mpi_esm_mr_rcp45_r1i1p1_200601_200612_sub.nc. ```
mishaschwartz
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Sep 13, 2023
## Overview Deprecate the `flyingpigeon` web processing service ## Changes **Non-breaking changes** - Removes flyingpigeon from the `DEFAULT_CONF_DIRS` list and moves its config files to the `deprecated-components` directory **Breaking changes** - If a deployment uses flyingpigeon they will need to specify it in the `EXTRA_CONF_DIRS` list ## Related Issue / Discussion ## Additional Information Links to other issues or sources. - Ouranosinc/pavics-sdi#296 - Ouranosinc/pavics-sdi#275 - Fixes #375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to clean-up some of the docs referring to old components.
This is still far from perfect, but no one likes to review huge PRs. The switch to myst_nb is not strictly necessary, but I think it will provide advantages, as the syntax is richer.