Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update finch notebook #156

Closed
huard opened this issue Mar 13, 2020 · 4 comments · Fixed by #157
Closed

Update finch notebook #156

huard opened this issue Mar 13, 2020 · 4 comments · Fixed by #157
Assignees
@huard

Comments

@huard
Copy link
Contributor

huard commented Mar 13, 2020

Finch 0.4.1 breaks finch notebook.
@huard huard mentioned this issue Mar 13, 2020
Merged
@huard huard self-assigned this Mar 16, 2020
@tlvu
Copy link
Contributor

tlvu commented Mar 16, 2020

Can we take this opportunity to keep only one of https://github.com/Ouranosinc/pavics-sdi/blob/master/docs/source/notebooks/finch.ipynb and https://github.com/bird-house/finch/blob/master/docs/source/notebooks/finch-usage.ipynb.

I vote to keep the one in the Finch repo and remove the duplicate one in Pavics-sdi. Else we'll need to double fix the notebooks for each change.

@huard
Copy link
Contributor Author

huard commented Mar 16, 2020

Good point, will do.

@tlvu
Copy link
Contributor

tlvu commented Mar 17, 2020

Finch notebook in Finch repo fixed in PR bird-house/finch#112

Remaining work: delete the duplicate Finch notebook in pavics-sdi.

@tlvu
Copy link
Contributor

tlvu commented Mar 17, 2020

@huard Humm the code is the same but the explanation text is slightly different between the 2 duplicated notebooks.

I was going to just delete the pavics-sdi one but now I think I'd rather let you review the explanation difference and "backport" them if needed.

@tlvu tlvu mentioned this issue Mar 17, 2020
Merged
@tlvu tlvu closed this as completed in #157 Mar 17, 2020
tlvu added a commit that referenced this issue Mar 17, 2020
@tlvu
Merge pull request #157 from Ouranosinc/delete-duplicated-finch-notebook

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8b07105 
finch.ipynb: deleted since duplicate with the one in Finch repo

Pr bird-house/finch#114 merged the explanation
differences between the 2 duplicate notebooks.

Fixes #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huard huard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

finch.ipynb: deleted since duplicate with the one in Finch repo Ouranosinc/pavics-sdi
2 participants
@huard @tlvu