Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update to use image pavics/workflow-tests:200427 #43

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented Apr 28, 2020

New build of our Jupyter env.

Required update to the notebooks for owslib and xarray breaking changes, see commit Ouranosinc/pavics-sdi@08325cb or PR Ouranosinc/pavics-sdi#170.

Noticeable changes:

# geopandas switched from conda to pip package
# this is a little bit odd since we pinned the conda version to 0.6.2
# should not be the cause of Jenkins failure since Raven tests are not enabled yet
<   - geopandas=0.6.2=py_0
>     - geopandas==0.7.0

<   - xarray=0.15.0=py_0
>   - xarray=0.15.1=py_0

<   - owslib=0.19.1=py_0
>   - owslib=0.19.2=py_1

<   - dask-core=2.12.0=py_0
>   - dask-core=2.15.0=py_0

<     - distributed==2.12.0
>     - distributed==2.15.0   

<     - xclim==0.14.0
>     - xclim==0.16.0

Full conda env export diff:
200312-200427-conda-env-export.diff.txt

Full new conda env content:
200427-conda-env-export.yml.txt

@tlvu tlvu requested review from huard and tlogan2000 April 28, 2020 17:24
@tlvu
Copy link
Contributor Author

tlvu commented Apr 28, 2020

New fancy html format output with drop down to collapse or expand data:

2020-04-28-134427_536x549_scrot

@tlogan2000
Copy link
Collaborator

Is WFS notebook the only one actually failing? I.e. other problems are due to new html output above

@tlvu
Copy link
Contributor Author

tlvu commented Apr 28, 2020

Is WFS notebook the only one actually failing? I.e. other problems are due to new html output above

I got the WFS notebook as well, will submit a PR on pavics-sdi side soon.

@tlvu
Copy link
Contributor Author

tlvu commented Apr 28, 2020

Ah geez, the html output format makes sanitizing the output much more complicated !

http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/new-docker-release-for-xclim/4/consoleFull still failing even with my changes on pavics-sdi side.

Still have to fix this or I might force old text format if that is possible.

tlvu added a commit to Ouranosinc/pavics-sdi that referenced this pull request Apr 29, 2020
…-jupyter-env


Update notebooks to match new Jupyter env.

To match new Jupyter env in PR Ouranosinc/PAVICS-e2e-workflow-tests#43.

New owslib 0.19.2 (we had 0.19.1 before) dropped the remaining of python 2 support so responses are now bytes instead of string.  See PR geopython/OWSLib#659 or commit geopython/OWSLib@79f9430.  I wouldn't expect a patch version release to drop python 2 support !

New xarray 0.15.1 default to html style output that allows collapsing/expanding data, see PR pydata/xarray#3812 or commit pydata/xarray@b155853.

![2020-04-28-134427_536x549_scrot](https://user-images.githubusercontent.com/11966697/80519794-89c80000-8956-11ea-8f0d-b95360b2d46c.png)
    
Unfortunately had to force the old text style since the html style has randomness that breaks automated testing of the notebooks using nbval pytest plugin.

Finally a passing Jenkins run: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/new-docker-release-for-xclim/5/console
@tlvu tlvu merged commit 446b2f1 into master Apr 29, 2020
@tlvu tlvu deleted the new-docker-release-for-xclim branch April 29, 2020 15:23
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Apr 29, 2020
See PR Ouranosinc/PAVICS-e2e-workflow-tests#43
(commit
Ouranosinc/PAVICS-e2e-workflow-tests@446b2f1)
for more info.

Noticeable changes:
```diff
<   - geopandas=0.6.2=py_0
>     - geopandas==0.7.0

<   - xarray=0.15.0=py_0
>   - xarray=0.15.1=py_0

<   - owslib=0.19.1=py_0
>   - owslib=0.19.2=py_1

<   - dask-core=2.12.0=py_0
>   - dask-core=2.15.0=py_0

<     - distributed==2.12.0
>     - distributed==2.15.0

<     - xclim==0.14.0
>     - xclim==0.16.0
```
@tlvu
Copy link
Contributor Author

tlvu commented Apr 29, 2020

I force xarray back to text output to avoid having to deal with sanitizing the html/css generated code.

tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Apr 29, 2020
jupyter: update to pavics/workflow-tests:200427 image

See PR Ouranosinc/PAVICS-e2e-workflow-tests#43 (commit Ouranosinc/PAVICS-e2e-workflow-tests@446b2f1) for more info.

Noticeable changes:
```diff
<   - geopandas=0.6.2=py_0
>     - geopandas==0.7.0

<   - xarray=0.15.0=py_0
>   - xarray=0.15.1=py_0

<   - owslib=0.19.1=py_0
>   - owslib=0.19.2=py_1

<   - dask-core=2.12.0=py_0
>   - dask-core=2.15.0=py_0

<     - distributed==2.12.0
>     - distributed==2.15.0

<     - xclim==0.14.0
>     - xclim==0.16.0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants