add option to enable/disable cronjobs #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Technically, this doesn't need any change in the code.
The docker-compose using CanarieAPI could override the cron file with only the specific items it needs to process.
By adding these options to CanarieAPI explicitly, I think it should also improve the way it reports the results on the API side as well. The JSON/HTML responses should include some information that options were disabled to indicate that last update: never is not due to an internal error or failing job.
mishaschwartz
force-pushed
the
optional-cron
branch
2 times, most recently
from
1c79afd to
44bd6b3
Compare
mishaschwartz
force-pushed
the
optional-cron
branch
from
44bd6b3 to
d674ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to independently enable/disable the two cron jobs that can be run (monitor, parse logs) using environment variables.
This PR contains a minimal version of the changes made in #18.