Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations, implement homeassistant-setting for babybuddy #48

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

MrApplejuice
Copy link
Contributor

@MrApplejuice MrApplejuice commented Jun 25, 2023

(Depends on a as of today uncommitted Babybuddy feature... which is why this is a draft atm)

Issue #47

Changes:

  • Select special homeassistant configuration of babybuddy to run
  • Update dependencies so that builds succeed
  • Switched around migration and createcachetable commands to fix migration step of installing the addon

@OttPeterR
Copy link
Owner

Thanks for teeing this up 👍 if there’s any changes in the meantime I might need you to merge from main but I’ll let you know!

@MrApplejuice
Copy link
Contributor Author

MrApplejuice commented Jun 25, 2023

Hey! No worries, testing it all was the costly bit that required all things to fall in place and be tested and verified. Updating from main should not be the issue. But let's wait first until this PR is merged:

babybuddy/babybuddy#672

That one is the prerequisite for this to be merged.

@MrApplejuice
Copy link
Contributor Author

Release 2.0 was published! Time to get this "fixed" :-)

@MrApplejuice MrApplejuice marked this pull request as ready for review July 10, 2023 22:21
@MrApplejuice
Copy link
Contributor Author

Alright. This should do the trick. Local testing tells me that this should build right now...

@reid
Copy link

reid commented Jul 15, 2023

Hey @MrApplejuice, I just wanted to leave a note here to thank you for this contribution and the work you have done in Baby Buddy to make this work.

This fix addresses my wife's top complaint with using Baby Buddy via Ingress when toasts cannot be dismissed!

I am very thankful for @OttPeterR also for maintaining this addon! I am a new dad and this tool has been so useful for my family. We are eagerly anticipating getting to use this fix but understand we are all busy being parents too 😃 thanks for all you are doing!

@MrApplejuice
Copy link
Contributor Author

Hey @reid - glad this helps with some other issues, too!

And thank you for the kind words!

@OttPeterR OttPeterR changed the base branch from main to v2.0.2 July 19, 2023 02:02
@OttPeterR
Copy link
Owner

I'm pulling in your changes into my v2.0.x branch and that'll ship when I finish my testing of the new stuff. Thanks again for the PR, I really appreciate it!

@OttPeterR OttPeterR merged commit ebc1e8c into OttPeterR:v2.0.2 Jul 19, 2023
OttPeterR added a commit that referenced this pull request Jul 26, 2023
* initial commit working on beta

* new build command

* 14.0.0 base image

* bump versions

* version bump

* Fix migrations, implement homeassistant-setting for babybuddy (#48)

* Fix migrations, implement homeassistant-setting for babybuddy

* Bump babybuddy version, enable new homeassistant support

---------

Co-authored-by: Peter Ott <[email protected]>

* 14.0.3 base image

* best practices

* add root user

* format

* bump base to 14.0.5

* download and extract differently

* build another way

* babybuddy 2.0.3

* swap migrate and cache create

* remove nap controls

---------

Co-authored-by: Paul K. Gerke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants