Q-Code #29
Closed
Q-Code #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sandarr95 Are you can create a unittest? |
Otann
reviewed
Sep 7, 2020
| Q-Codes in Morse are shorthands for common patterns. `morse.qcodes/direct-reply` & `morse.qcodes/req-morse` are the Q-Codes already available. Here is an example usage of both. | ||
|
|
||
| ```clojure | ||
| (ns look.anotherbadlynamedns |
There was a problem hiding this comment.
the rest of the docs uses slightly different style of imports
| [morse.handlers :as h] | ||
| [somehttpserver :as http])) | ||
|
|
||
| (def token "") |
There was a problem hiding this comment.
Also the is no need repeat what was there before
| @@ -0,0 +1,11 @@ | |||
| {:paths ["src"] | |||
There was a problem hiding this comment.
it is quite confusing to have two sources of dependencies, because people would need to keep them both up to date
There was a problem hiding this comment.
I forgot about this PR as well, this was added to do some troubleshooting. I'll look into fixing up this PR again next weekend.
| #{(s/tuple "getMe" ::getMe) | ||
| (s/tuple "sendMessage" ::sendMessage)}) | ||
|
|
||
| (s/def ::request |
There was a problem hiding this comment.
I don't see it used anywhere, maybe left here by mistake?
|
Cleaned this up in #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left it really simple for now, just 2 functions in qcodes.clj.
One will auto reply any text returned by the handler.
The other is middleware, causing the handler to work the same for polling and webhooks (and can also be made secure).
Let me know what you think.
Also had the idea to make a single function to start the bot, so if you provide a webhook it will use a server, but not sure how to make people choose what server they want to use.