Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change scan timeout in local scans #849

Merged

Conversation

elyousfi5
Copy link
Member

Add option to change scan timeout value in local scans.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.85%. Comparing base (9dba81f) to head (99d8433).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/cli/scan/run/run.py 50.00% 2 Missing ⚠️
src/ostorlab/runtimes/local/runtime.py 75.00% 1 Missing ⚠️
src/ostorlab/runtimes/runtime.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   62.65%   62.85%   +0.20%     
==========================================
  Files         342      342              
  Lines       14520    14566      +46     
==========================================
+ Hits         9097     9156      +59     
+ Misses       5423     5410      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elyousfi5 elyousfi5 marked this pull request as ready for review January 6, 2025 13:50
@elyousfi5 elyousfi5 requested a review from a team as a code owner January 6, 2025 13:50
ohachimOs
ohachimOs previously approved these changes Jan 6, 2025
oussamaessaji
oussamaessaji previously approved these changes Jan 6, 2025
benyissa
benyissa previously approved these changes Jan 6, 2025
nmasdoufi-ol
nmasdoufi-ol previously approved these changes Jan 7, 2025
src/ostorlab/runtimes/local/runtime.py Outdated Show resolved Hide resolved
@elyousfi5 elyousfi5 merged commit c5d9be6 into main Jan 7, 2025
10 checks passed
@elyousfi5 elyousfi5 deleted the feature/add-option-to-change-scan-timeout-in-local-scans branch January 7, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants