Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor imports and fix oxo should exit once the scan has completed #783

Closed
wants to merge 13 commits into from

Conversation

elyousfi5
Copy link
Member

@elyousfi5 elyousfi5 commented Aug 13, 2024

Test approach:

built an agent and tried to import some modules that were failing before:
image

built some agents (nmap, autoscaler, virustotal) with this version of oxo and ran scan with them:

AgentGroup:

name: test_oxo
kind: AgentGroup
description: Agent group definition for oxo testing.
agents:
  - args: [ ]
    key: agent/dev/nmap
  - args: [ ]
    key: agent/dev/virustotal
  - args: [ ]
    key: agent/dev/autoscaler

Logs of agents:
image
image

@elyousfi5 elyousfi5 changed the title refactor main and remote init.py refactor main and init.py Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 84.72222% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (8205b10) to head (bfdba32).
Report is 13 commits behind head on main.

Files Patch % Lines
src/ostorlab/main.py 0.00% 10 Missing ⚠️
src/ostorlab/runtimes/local/log_streamer.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #783       +/-   ##
===========================================
+ Coverage   62.63%   80.33%   +17.69%     
===========================================
  Files         341      340        -1     
  Lines       14153    14141       -12     
===========================================
+ Hits         8865    11360     +2495     
+ Misses       5288     2781     -2507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adnaneserrar
adnaneserrar previously approved these changes Aug 15, 2024
@elyousfi5 elyousfi5 changed the title refactor main and init.py refactor imports Aug 15, 2024
src/ostorlab/agent/agent_fetcher.py Outdated Show resolved Hide resolved
src/ostorlab/cli/auth/revoke/revoke.py Outdated Show resolved Hide resolved
@elyousfi5 elyousfi5 marked this pull request as ready for review August 15, 2024 13:15
@elyousfi5 elyousfi5 changed the title refactor imports refactor imports and fix oxo should exit once the scan has completed Aug 15, 2024
from ostorlab.assets import android_store as android_store_asset
from ostorlab import exceptions
from ostorlab import exceptions, console as cli_console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply for the rest

@elyousfi5 elyousfi5 marked this pull request as draft August 15, 2024 13:33
@elyousfi5 elyousfi5 closed this Aug 15, 2024
@elyousfi5 elyousfi5 deleted the fix/refactor-main branch August 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants