-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor imports and fix oxo should exit once the scan has completed #783
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
===========================================
+ Coverage 62.63% 80.33% +17.69%
===========================================
Files 341 340 -1
Lines 14153 14141 -12
===========================================
+ Hits 8865 11360 +2495
+ Misses 5288 2781 -2507 ☔ View full report in Codecov by Sentry. |
from ostorlab.assets import android_store as android_store_asset | ||
from ostorlab import exceptions | ||
from ostorlab import exceptions, console as cli_console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply for the rest
Test approach:
built an agent and tried to import some modules that were failing before:
built some agents (nmap, autoscaler, virustotal) with this version of oxo and ran scan with them:
AgentGroup:
Logs of agents: