Skip to content

Commit

Permalink
Merge pull request #7 from Ostorlab/fix_wrong_example_in_readme
Browse files Browse the repository at this point in the history
Fix Docker file and readme.
  • Loading branch information
amine3 authored Sep 28, 2022
2 parents de9e694 + 94109bf commit 4805464
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 18 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ jobs:
ostorlab_api_key: ${{ secrets.ostorlab_api_key }} # your secret api key.
break_on_risk_rating: HIGH # Wait for the scan results and force the action to fail if the scan risk is higher
max_wait_minutes: 30
- name: Get scan id
run: echo "Scan Created with id ${{ steps.start_scan.outputs.scan_id }}"
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
FROM python:3.8-slim-buster as base
FROM python:3.10-alpine as base
FROM base as builder
RUN apk add build-base
RUN mkdir /install
WORKDIR /install
RUN pip install --prefix=/install ostorlab
Expand Down
36 changes: 19 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,26 @@ The next steps is to a update your workflow to add an Ostorlab step to trigger t
a rapid scan on an Android APK and failing the pipeline on vulnerabilities with `HIGH` severity.

```yaml
on: [push]
on: [ push ]
jobs:
ostorlab_test:
runs-on: ubuntu-latest
name: Test ostorlab ci actions.
steps:
- uses: actions/checkout@v2
- name: Launch Ostorlab scan
id: start_scan
uses: actions/ostorlab_actions@v1
with:
scan_profile: fast_scan
asset_type: android-apk
target: andoird_apk.apk
can_title: title_scan_ci
ostorlab_api_key: ${{ secrets.ostorlab_api_key }} # your secret api key.
break_on_risk_rating: HIGH
max_wait_minutes: 20
ostorlab_test:
runs-on: ubuntu-latest
name: Test ostorlab ci actions.
steps:
- uses: actions/checkout@v2
- name: build ostorlab.apk
run: mv InsecureBankv2.apk ostorlab.apk
- name: Launch Ostorlab scan
id: start_scan
uses: Ostorlab/[email protected]
with:
scan_profile: fast_scan # Specify which scan profile to use for the scan (check scan section).
asset_type: android-apk # type of asset to scan.
target: ostorlab.apk # path for target tto scan.
scan_title: title_scan_ci # type a title for your scan.
ostorlab_api_key: ${{ secrets.ostorlab_api_key }} # your secret api key.
break_on_risk_rating: HIGH # Wait for the scan results and force the action to fail if the scan risk is higher
max_wait_minutes: 30
```
### Action inputs
Expand Down

0 comments on commit 4805464

Please sign in to comment.