Catches the UnicodeError from whois.whois #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 97.96% 98.07% +0.11%
==========================================
Files 4 4
Lines 295 312 +17
==========================================
+ Hits 289 306 +17
Misses 6 6 ☔ View full report in Codecov by Sentry. |
nmasdoufi-ol
reviewed
Dec 2, 2024
benyissa
reviewed
Dec 2, 2024
benyissa
previously approved these changes
Dec 2, 2024
PiranhaSa
previously approved these changes
Dec 2, 2024
3asm
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Unicode errors in WHOIS domain fetch
Adds error handling for invalid domain characters to prevent crashes when processing malformed domains.
Ticket-os-13354