Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Virus_total_key argument #27

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Adding Virus_total_key argument #27

merged 10 commits into from
Dec 6, 2024

Conversation

PiranhaSa
Copy link
Contributor

@PiranhaSa PiranhaSa commented Dec 2, 2024

In this PR I've added the support for virustotal api key, so subfinder can use it . we can do that by adding the key to the provider-config.yaml conf file.

From inside the agent:
Screenshot from 2024-12-06 11-59-22

As you can see here, the virustotal API is called:
image
image

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (a35b197) to head (1ba0e76).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   90.09%   94.78%   +4.69%     
==========================================
  Files           4        4              
  Lines         111      211     +100     
==========================================
+ Hits          100      200     +100     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amine3
amine3 previously requested changes Dec 3, 2024
agent/subfinder_agent.py Outdated Show resolved Hide resolved
@PiranhaSa PiranhaSa marked this pull request as draft December 3, 2024 10:35
@PiranhaSa PiranhaSa marked this pull request as ready for review December 4, 2024 08:00
@3asm 3asm marked this pull request as draft December 4, 2024 14:52
@PiranhaSa PiranhaSa marked this pull request as ready for review December 4, 2024 17:23
Copy link

@nmasdoufi-ol nmasdoufi-ol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

requirement.txt Outdated Show resolved Hide resolved
ostorlab.yaml Outdated Show resolved Hide resolved
tests/subfinder_agent_test.py Outdated Show resolved Hide resolved
agent/subfinder_agent.py Outdated Show resolved Hide resolved
@3asm 3asm marked this pull request as draft December 5, 2024 09:22
@elyousfi5 elyousfi5 marked this pull request as ready for review December 6, 2024 11:07
@3asm 3asm dismissed amine3’s stale review December 6, 2024 11:09

Comments fixed.

@3asm 3asm merged commit 4f2f7ea into main Dec 6, 2024
4 checks passed
@3asm 3asm deleted the feature/adding_virustotal_key branch December 6, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants