Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scan link. #61

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Add support for scan link. #61

merged 5 commits into from
Jul 24, 2024

Conversation

3asm
Copy link
Member

@3asm 3asm commented Jul 24, 2024

The PR adds support for the scan.
It also addresses 2 bugs. The 1st one is that guessing the file name will stop at the first which is often wrong.
The 2nd bug is an issue in osv not supporting int version.

An issue has been opened with osv project. Awaiting a fix, a hot patch of the content is done to make it compatible with osv.

tests/hotpatch_test.py Outdated Show resolved Hide resolved
agent/osv_agent.py Show resolved Hide resolved
agent/hotpatch.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.94%. Comparing base (2a9aa6d) to head (6f7a995).

Files Patch % Lines
agent/osv_agent.py 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   94.82%   94.94%   +0.12%     
==========================================
  Files          11       13       +2     
  Lines         792      851      +59     
==========================================
+ Hits          751      808      +57     
- Misses         41       43       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3asm 3asm merged commit 22c69ff into main Jul 24, 2024
5 checks passed
@3asm 3asm deleted the feature/scan_link branch July 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants