Report actual protocol such as ssh,http not tcp/udp.
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 94.68% 94.66% -0.03%
==========================================
Files 9 9
Lines 922 918 -4
==========================================
- Hits 873 869 -4
Misses 49 49 ☔ View full report in Codecov by Sentry. |
mohsinenar
changed the title
ssh,http not tcp.ssh,http not tcp/udp.
nmasdoufi-ol
approved these changes
Nov 7, 2024
amine3
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nmap was consistently reporting the protocol as either UDP or TCP.
This PR fix this issue by reporting the correct value.