Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nmap to latest version #104

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Update nmap to latest version #104

merged 8 commits into from
Sep 4, 2024

Conversation

ohachimOs
Copy link
Member

@ohachimOs ohachimOs commented Sep 3, 2024

The version we have is the latest that is supported by Ubuntu (7.91), but the most recent Nmap version is 7.95
Using apt update && apt upgrade won't give us the latest version.
image
image

Using apt update && apt upgrade does not update it as
If we want the latest version we have to go for source code installation.
The steps added to Dockerfile:

  1. Download source code nmap-7.95.tar.bz2
  2. Extract content
  3. Install Nmap requirements
  4. Install Nmap

Extra files will exist in a tmp file that gets deleted after.
image

Scan running on 8.8.8.8:
image

Scan on a certain IP-Address (143.109.120.194): nmap: 7.95
image

Same IP address with old Agent Nmap:
image

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (91a788f) to head (654832f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   94.55%   94.59%   +0.04%     
==========================================
  Files           9        9              
  Lines         900      907       +7     
==========================================
+ Hits          851      858       +7     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohachimOs ohachimOs marked this pull request as ready for review September 3, 2024 10:21
@ohachimOs ohachimOs changed the title Update nmap Update nmap to latest version Sep 3, 2024
Copy link

@nmasdoufi-ol nmasdoufi-ol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ostorlab.yaml shows empty file?

@ohachimOs
Copy link
Member Author

ohachimOs commented Sep 3, 2024

Why ostorlab.yaml shows empty file?

I changed its rights, it had execution rights which it doesn't need
Empty file as in no changes were made
@nmasdoufi-ol

amine3
amine3 previously requested changes Sep 3, 2024
Copy link
Member

@amine3 amine3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the agent locally? Can you share a screenshot

@ohachimOs ohachimOs changed the title Update nmap to latest version Update nmap to latest version [No merge, needs testing] Sep 3, 2024
@ohachimOs
Copy link
Member Author

Yes I did, but I should do more tests
Agent starting normally
image

image

image

image

@amine3
Copy link
Member

amine3 commented Sep 3, 2024

Yes I did, but I should do more tests Agent starting normally image

image

image

image

There is something off, ther version is 93 while you seem installing 95
image

@ohachimOs
Copy link
Member Author

Yes I did, but I should do more tests Agent starting normally image
image
image
image

There is something off, ther version is 93 while you seem installing 95 image

Oh right! I used 7.93 before going to 7.95, the results are similar though, I will update PR description

@ohachimOs ohachimOs marked this pull request as draft September 3, 2024 12:08
Dockerfile Outdated Show resolved Hide resolved
@ohachimOs ohachimOs requested review from amine3 and 3asm September 3, 2024 14:15
@ohachimOs ohachimOs marked this pull request as ready for review September 3, 2024 14:15
@ohachimOs ohachimOs changed the title Update nmap to latest version [No merge, needs testing] Update nmap to latest version Sep 3, 2024
Dockerfile Outdated Show resolved Hide resolved
@3asm 3asm dismissed amine3’s stale review September 4, 2024 00:00

Comments fixed.

@3asm 3asm merged commit bef4204 into main Sep 4, 2024
5 checks passed
@3asm 3asm deleted the fix/update_nmap branch September 4, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants